fix(cubesql): Use pushdown-pullup scheme for FilterSimplifyReplacer #9278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9278 +/- ##
==========================================
+ Coverage 83.68% 83.73% +0.05%
==========================================
Files 228 228
Lines 82016 82249 +233
==========================================
+ Hits 68632 68875 +243
+ Misses 13384 13374 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MazterQyou
approved these changes
Mar 3, 2025
mcheshkov
force-pushed
the
filter-replacer-push-pull
branch
from
7df76e1 to
e8997bd
Compare
MazterQyou
approved these changes
Mar 4, 2025
mcheshkov
force-pushed
the
filter-replacer-push-pull
branch
from
e8997bd to
9333240
Compare
MazterQyou
approved these changes
Mar 4, 2025
This should avoid unexpected unifications of simplified expression in unrelated context. For example, same expression can be present in filter and projection, but due to over-unification in filters it can receive different representation in projection, and break aliases later, during extraction
mcheshkov
force-pushed
the
filter-replacer-push-pull
branch
from
9333240 to
9d2daaf
Compare
MazterQyou
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
This should avoid unexpected unifications of simplified expression in unrelated context. For example, same expression can be present in filter and projection, but due to over-unification in filters it can receive different representation in projection, and break aliases later, during extraction